Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize text input location and search glob #51

Open
rstarmer opened this issue Jun 30, 2023 · 1 comment
Open

Parameterize text input location and search glob #51

rstarmer opened this issue Jun 30, 2023 · 1 comment
Labels
P1 Priority 1

Comments

@rstarmer
Copy link
Member

rstarmer commented Jun 30, 2023

The retrieval library and or sample should be parameterized so that it can more readily be used to test against a wider set of target parameters. This issue is related to PR #50 for when that merges.

Acceptance would be the ability to point to a directory as input to a training and validation test.

@sdake sdake added the P1 Priority 1 label Jul 2, 2023
@sdake
Copy link
Member

sdake commented Jul 2, 2023

@MostAwesomeDude @rstarmer @lsdake @sdake I will NOT submit config.py as part of PR #50. Therefore, please consider self-assigning this issue to implement this in the next few days. Until then, we can use hardcode config...

For some inspiration, may I suggest taking a look at the excellent Pytorch Lightning project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1
Projects
None yet
Development

No branches or pull requests

2 participants