Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rendering] calculate bloom in lower resolution #76

Closed
wants to merge 1 commit into from

Conversation

fall2019
Copy link
Member

No description provided.

@fall2019 fall2019 requested a review from MomoDeve June 19, 2023 14:54
@fall2019 fall2019 self-assigned this Jun 19, 2023
@fall2019 fall2019 added the enhancement refactoring or optimization label Jun 19, 2023
@fall2019 fall2019 marked this pull request as ready for review June 19, 2023 15:14
@@ -344,7 +344,7 @@ namespace MxEngine
for (auto& bloomTexture : environment.BloomTextures)
{
bloomTexture = Factory<Texture>::Create();
bloomTexture->Load(nullptr, bloomBufferSize, bloomBufferSize, 3, false, HDRTextureFormat);
bloomTexture->Load(nullptr, bloomBufferSize / 2, bloomBufferSize / 2, 3, false, HDRTextureFormat);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bloomBufferSize is already 512 and taken from config (see EngineTextureSize)

@fall2019 fall2019 closed this Jun 19, 2023
@fall2019 fall2019 deleted the calc_bloom_in_lower_resolution branch June 22, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement refactoring or optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rendering] Test existing algorithms in half / quater resolution with increased sample count
2 participants