Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Upcoming updates to this package #396

Open
6 tasks
ArtemKolichenkov opened this issue May 13, 2020 · 1 comment
Open
6 tasks

Upcoming updates to this package #396

ArtemKolichenkov opened this issue May 13, 2020 · 1 comment

Comments

@ArtemKolichenkov
Copy link
Collaborator

Upcoming updates to this package

Hello everybody!
Thanks to @ascoders I've become a maintainer for this and related repo react-native-image-zoom

I have some free time now to go through issues and provide some fixes/features. I will spend around 2 hours each day working on this project, hopefully bringing it to a better shape by June.

Rough idea for the current major version of this package is:

  • Update tooling (e.g. adopt ESLint since TSLint is deprecated, as well as other devX improvements)
  • Go through PRs
  • Go through Issues looking which ones make sense to implement, address questions, fix bugs, etc.
  • Incorporate changelog
  • Update documentation
  • Maybe make better demo project to test things out + some automated tests

All backwards-compatible changes will be released under 3.1.x version.

After that work is done I'd like to go away from class-based component to functional component + hooks since it is the modern (and the future) way to write React and it is also easier to read and reason about code. Especially for "small" components like this one.
But I'd suggest to leave it for future major release 4.x.x since even though it probably gonna be backwards-compatible it would be a nice way to mark the point in time for this kind of major refactoring step (we might also plug in some non-backwards-compatible stuff at this point too).

Note: since this package depends on react-native-image-zoom I'll spend more time with that one at the beginning.

Let's use this issue as a discussion topic. I will also update this top comment with the progress status.

P.S. I know it sounds like a big update and you want to run npm update react-native-image-zoom-viewer already, but please be patient, since I can't work all day on this some updates can take some time before they reach npm.

@ArtemKolichenkov
Copy link
Collaborator Author

Small update - I've been doing some fixes to the repo this package depends on, read more here:
ascoders/react-native-image-zoom#129

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant