Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

is it need to build? #40

Closed
mmz211 opened this issue Jan 26, 2018 · 5 comments
Closed

is it need to build? #40

mmz211 opened this issue Jan 26, 2018 · 5 comments

Comments

@mmz211
Copy link

mmz211 commented Jan 26, 2018

I used react-native-image-zoom in react native project.

I modified image-zoom/image-zoom.component.tsx and reload it from top view. but what I see from this url (http://127.0.0.1:8081/index.ios.bundle?platform=ios&dev=true&minify=false), is the original source of react-native-image-zoom.

I'd like to know if it needed to build after modification? As I see build folder in the source dictionary.
And how to build it? "tsc index.ts"?

@mmz211
Copy link
Author

mmz211 commented Jan 26, 2018

"tsc index.ts" failed

bash-3.2$ tsc index.ts
index.ts(1,23): error TS6142: Module './image-zoom/image-zoom.component' was resolved to '/Users/admin/Workspace/TestSVN/node_modules/react-native-image-pan-zoom/image-zoom/image-zoom.component.tsx', but '--jsx' is not set.

@mmz211
Copy link
Author

mmz211 commented Jan 26, 2018

"tsc index.ts --jsx react" is right.

I guessed "tsc index.ts --jsx".

New problem while compiling
"image-zoom/image-zoom.component.tsx(95,135): error TS2339: Property 'props' does not exist on type 'ImageViewer' "

@ascoders
Copy link
Owner

You can see develop document here.

@ArtemKolichenkov
Copy link
Collaborator

I will update development docs soon as part of #129

@ArtemKolichenkov
Copy link
Collaborator

Closing this issue, dev docs will be improved when #131 closes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants