Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for msys2 on windows #92

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for msys2 on windows #92

wants to merge 5 commits into from

Conversation

dominicletz
Copy link

@dominicletz dominicletz commented Dec 15, 2022 •
edited
Loading

Thanks for the great plugin @kennyp ❤ ! This PR adds windows support when using the msys2 bash and linux tooling.

@kennyp
Copy link
Member

kennyp commented Dec 17, 2022 •
edited
Loading

@dominicletz mind updating .github/workflows/main.yml to include windows as well? Thanks!

@dominicletz
Copy link
Author

Hm, would love to, but it looks like the asdf-vm/actions/plugin-test@v1 is not windows compatible at all. So someone will have to fix that, or replace the CI steps here with simple bash to test the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominicletz @kennyp