Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema manifest providing package version to asdf metadata and check schema packages on read #1741

Open
braingram opened this issue Jan 29, 2024 · 0 comments

Comments

@braingram
Copy link
Contributor

Description of the problem

Currently many asdf extensions (gwcs, asdf-astropy, roman_datamodels) rely on manifests and schemas provided by a different package (asdf-wcs-schemas, asdf-transform-schemas, rad, etc).

However, the versions of these schema packages are not included in the metadata written to an asdf file that was validated against the schemas and use tags from the manifests.

Consider options for adding information about these schema packages to the asdf metadata including:

  • when a manifest exists (checked using the uri) for an extension used to create an ASDF file, include the version of the manifest-providing-package in the metadata
  • when validating a file, log which schemas are used for validation and include the packages that provide these schemas in the metadata

This new schema-providing-package metadata can be checked on read (similar to how extensions are checked) to provide (hopefully) useful messages to users that open files that expect resources that are not installed.

System information

asdf version:
python version:
operating system:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant