Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datatype validator is overly strict and doesn't allow extra schema items #1900

Open
braingram opened this issue Feb 7, 2025 · 0 comments · May be fixed by #1901
Open

datatype validator is overly strict and doesn't allow extra schema items #1900

braingram opened this issue Feb 7, 2025 · 0 comments · May be fixed by #1901

Comments

@braingram
Copy link
Contributor

There is nothing in the datatype portion of the ndarray schema that prevents additional schema items.
https://github.com/asdf-format/asdf-standard/blob/c17c3ecabcad7b65e41e0fb79054988b37f45a38/resources/schemas/stsci.edu/asdf/core/ndarray-1.1.0.yaml#L214
However asdf fails exact_datatype=True validation if the datatype schema contains extra fields (like description for structured datatype items).
@braingram braingram linked a pull request Feb 7, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow extra keywords in structured datatype validation braingram/asdf
1 participant
@braingram