Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance getAuthorizationURL Function to Support POST Requests #250

Closed
movinsilva opened this issue Apr 2, 2024 · 1 comment
Closed

Enhance getAuthorizationURL Function to Support POST Requests #250

movinsilva opened this issue Apr 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request Type/New Feature

Comments

@movinsilva
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The getAuthorizationURL function within the AuthenticationCore class of the Asgardeo Auth JS Core currently only provides a GET request for authorization. However, for API-based authentication, POST requests are typically utilized. This limitation complicates the integration of the package into other SDKs that require API-based authentication.

Describe the solution you would prefer

Ideally, I'm requesting an extension of the getAuthorizationURL function to accommodate POST requests as well. This would involve enhancing the existing function to support both GET and POST methods for authorization, providing developers with a unified interface for authentication operations.

However, recognizing the generic nature of this package and the distinct concern of API-based authentication, if the above implementation is not feasible within the scope of the SDK, an alternative solution would involve separating the logic within the existing getAuthorizationURL function. By isolating the core logic, developers could then utilize this functionality to construct a POST request within their respective SDKs.

@movinsilva
Copy link
Contributor Author

New getAuthorizationURLParams function is exposed now from this effort. Refer this link for more details about this function.

Added this with Enhance getAuthorizationURL function PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Type/New Feature
Projects
None yet
Development

No branches or pull requests

2 participants