Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing validations for the REQUIRED configurations. #14

Open
chamathns opened this issue Nov 2, 2020 · 0 comments
Open

Add missing validations for the REQUIRED configurations. #14

chamathns opened this issue Nov 2, 2020 · 0 comments

Comments

@chamathns
Copy link
Contributor

Description:
In the Configurations catalog added with asgardeo/asgardeo-tomcat-oidc-agent@0ec2633, some properties are marked as REQUIRED in the app.properties file.
In the config provider or in the DefaultOIDCManager constructor, we need to validate these properties that are marked as REQUIRED.

As of now, validations for the following properties are implemented.

  • Consumer Key / Client ID
  • Consumer Secret / Client Secret
  • Callback URI / Redirect URI
  • Scope

Missing validations for the other REQUIRED parameters must also be added there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant