Skip to content

Commit 734ce73

Browse files
committed
simplify updating logic
1 parent 9b96df8 commit 734ce73

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

backend/services/operation_role.go

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,20 +128,15 @@ func SetUserGroupOperationRole(ctx context.Context, db *database.Connection, i S
128128
"operation_id": operation.ID,
129129
"role": i.Role,
130130
})
131+
} else if permissions[0].Role != i.Role {
132+
tx.Update(sq.Update("user_group_operation_permissions").
133+
Set("role", i.Role).
134+
Where(sq.Eq{"group_id": userGroupID, "operation_id": operation.ID}))
131135
}
132136
})
133137
if err != nil {
134138
return backend.WrapError("Unable to add user role", backend.DatabaseErr(err))
135139
}
136140

137-
if len(permissions) > 0 && permissions[0].Role != i.Role {
138-
err = db.Update(sq.Update("user_group_operation_permissions").
139-
Set("role", i.Role).
140-
Where(sq.Eq{"group_id": userGroupID, "operation_id": operation.ID}))
141-
142-
if err != nil {
143-
return backend.WrapError("Unable to alter user role", backend.DatabaseErr(err))
144-
}
145-
}
146141
return nil
147142
}

0 commit comments

Comments
 (0)