Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive highlight color from foreground knob color #7

Open
ColonelClink opened this issue Apr 21, 2018 · 0 comments
Open

Derive highlight color from foreground knob color #7

ColonelClink opened this issue Apr 21, 2018 · 0 comments

Comments

@ColonelClink
Copy link

painter->restore();
painter->setBrush(Qt::white);
painter->drawEllipse(boundingRect().center(),w/d,w/d);

I am attempting to use a darker theme for the knobs, but the highlight color is hard coded to white, which presents problems with several colors. Instead I would prefer it be set to be relative to the foreground color of the knob: 35-50% lighter and 20-30% desaturated. This should dramatically improve the appearance of dark theming.

I would submit a pull request but I am not yet familiar enough with Qt (or C++, I am a Java programmer). How would you go about doing this? I may be able to figure it out with some guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant