Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between train.py and src/train.py in Readme #623

Open
alexkrz opened this issue Dec 5, 2023 · 0 comments · May be fixed by #624
Open

Inconsistency between train.py and src/train.py in Readme #623

alexkrz opened this issue Dec 5, 2023 · 0 comments · May be fixed by #624

Comments

@alexkrz
Copy link

alexkrz commented Dec 5, 2023

I am trying this great template and noticed some inconsistencies with references to train.py / src/train.py in the Readme file.
I assume the train script has been moved to the src/ folder at a later stage.
In my previous projects, I used to have the train and eval scripts at the root of the directory.
However, I get the design choice, that you seem to want to have all python files in the src/ folder.
I will draft a PR to adjust all references from train.py to src/train.py.
I also noticed that the screenshot from the config overview refers to a not existing run.py script.

@alexkrz alexkrz linked a pull request Dec 5, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant