What happened?
The advice in CONTRIBUTING.md is to run pre-commit on your contributions.
However, when I ran pre-commit run --all-files it found formatting problems in 45 files that were unrelated to my contribution (for #825).
So,
- Is the advice in CONTRIBUTING.md correct?
- Are the formatting checks being enforced by your CI?
- Do you want a PR consisting only of the formatting changes performed by
pre-commit run --all-files?
Version
Development (host) and target OS/architectures: MacOS Sequoia 15.5 / amd64
Output of bazel --version:
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: HEAD
Language(s) and/or frameworks involved:
How to reproduce
pre-commit run --all-files
Any other information?
No response
What happened?
The advice in CONTRIBUTING.md is to run pre-commit on your contributions.
However, when I ran
pre-commit run --all-filesit found formatting problems in 45 files that were unrelated to my contribution (for #825).So,
pre-commit run --all-files?Version
Development (host) and target OS/architectures: MacOS Sequoia 15.5 / amd64
Output of
bazel --version:Version of the Aspect rules, or other relevant rules from your
WORKSPACEorMODULE.bazelfile: HEADLanguage(s) and/or frameworks involved:
How to reproduce
Any other information?
No response