[Bug]: Strip import prefixes not handled correctly in ts_proto_library

[purkhusid]

What happened?

The ts_proto_library rules does not have handling for strip_import_prefix (And probably not import_prefix?).

If you use strip_import_prefix the import statements in the generated js/d.ts files are wrong since the prefix also gets stripped from the relative import paths. The import paths should not be stripped since the real source files are not moved when using strip_import_prefix but bazel just creates a virtual folder structure that makes it possible for the protoc compiler to resolve proto imports that have stripped prefixes.

I'm not sure how to solve this but I'm fairly sure that this has to be handled in ts_proto_library since strip_import_prefix is just a Bazel-ism.

Version

Development (host) and target OS/architectures: MacOS

Output of bazel --version: 8.3.1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:
Latest rules_js/rules_ts

Language(s) and/or frameworks involved:
JavaScript, TypeScript, Protobuf

How to reproduce

Any other information?

No response

[purkhusid]

Here is a patch that I use to work around our specific usage of strip_import_prefix:

diff --git ts/private/ts_proto_library.bzl ts/private/ts_proto_library.bzl
index 099c35d..3024067 100644
--- ts/private/ts_proto_library.bzl
+++ ts/private/ts_proto_library.bzl
@@ -152,6 +152,26 @@ def _declare_outs(ctx, info, ext):
 
     return outs
 
+def _replace_import_prefix_hack(ctx, file):
+    # Note that we don't use sibling here becuase the original output
+    # is creqated inside the virtual_imports folder that is created by
+    # proto_library when strip_import_prefix is used
+    output = ctx.actions.declare_file(file.basename.replace("_pb", ""))
+    ctx.actions.run_shell(
+        inputs = [file],
+        outputs = [output],
+        # This is a very naive fix, we'll see if I have to make it more robust
+        command = """
+            cat {} | sed 's|../google|../src/protobuf/google|g; s|_pb||g' > {}
+        """.format(
+            file.path,
+            output.path,
+        ),
+        mnemonic = "TSProtoImportPrefixHack",
+    )
+
+    return output
+
 def _ts_proto_library_impl(ctx):
     info = ctx.attr.proto[ProtoInfo]
     js_outs = _declare_outs(ctx, info, ".js")
@@ -159,9 +179,20 @@ def _ts_proto_library_impl(ctx):
 
     _protoc_action(ctx, info, js_outs + dts_outs)
 
+    # This hack fixes an issue with `strip_import_prefix`. The generated files also get the
+    # prefix removed from the import paths which leads to incorrect imports.
+    # This has to be either fixed here or in protoc-gen-es.
+    # We only need this due to the reason that we vendor the gooogleapis under src/protobuf/google
+    # and we need to use strip_import_prefix=src/protobuf so that the imports to google/protobuf/xyz.proto
+    # work correctly.
+    # Issue:https://github.com/aspect-build/rules_ts/issues/875
+    fixed_files = []
+    for file in dts_outs + js_outs:
+        fixed_files.append(_replace_import_prefix_hack(ctx, file))
+
     return [
         DefaultInfo(
-            files = depset(js_outs + dts_outs),
+            files = depset(fixed_files),
         ),
     ]

If there are any good ideas on how to generalize this then I could take a stab at implementing it.

[alexeagle]

I just sent the PR for this yesterday! #874
does that work for you?

[ramilmsh]

thanks for looking into it, for some context: i've run into this same exact issue when trying to bundle proto files with esbuild/rollup/webpack/vite. ts_project works great, but the bundlers cannot find the sources

[mbgit2]

Will there com a fix anytime soon? I'm also running into this issue, it would be greatly appreciated.