-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce run time for tests for diploid Viterbi implementations #65
Comments
@jeromekelleher suggested to exclude running the naive implementations, since we will not be using them in the API. Also, we should aim for tests that don't run longer than 30 seconds or so. |
Naive diploid Viterbi takes rather long when run on ref. panels simulated from |
By reducing the recombination rate to simulate ref. panels for |
These tests take a long time to run:
|
Ideally, we implement a naive version of diploid Viterbi that scales better, but that will take more work. For now, we can reduce the run times of the |
Some tests for the naive diploid Viterbi implementations are rather slow when the reference panel includes ancestral haplotypes and gets moderately large. For example, the tests took ~40 minutes to complete for PR #64, even when tests are skipped when the reference panel exceeds 100 haplotypes. Should we run tests that take this long?
The text was updated successfully, but these errors were encountered: