Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv not installing build dependencies #5399

Closed
EdvardsZ opened this issue Jul 24, 2024 · 1 comment
Closed

uv not installing build dependencies #5399

EdvardsZ opened this issue Jul 24, 2024 · 1 comment

Comments

@EdvardsZ
Copy link

EdvardsZ commented Jul 24, 2024

  • A minimal code snippet that reproduces the bug :
    uv pip install git+https://github.com/nerfstudio-project/gsplat
  File "<string>", line 152, in <module>
  File "<string>", line 33, in get_extensions
ModuleNotFoundError: No module named 'torch'
---
  Caused by: This error likely indicates that git+https://github.com/nerfstudio-project/gsplat depends on torch, but doesn't declare it as a build dependency. If git+https://github.com/nerfstudio-project/gsplat is a first-party package, consider adding torch to its `build-system.requires`. Otherwise, `uv pip install torch` into the environment and re-run with `--no-build-isolation`.
  • However when using pip with pip install git+https://github.com/nerfstudio-project/gsplat
    Everything installs correctly!

Ofcourse when I install torch and use --no-build-isolation then uv installs it as well.

I think that uv fails to install build dependencies from setup.py (install-requires).

I am python build tool newbie, it could be that I am somehow mistaken

@konstin
Copy link
Member

konstin commented Jul 24, 2024

This is another case of #2252. The difference between pip and uv is intentional, closing this since --no-build-isolation solves this for your case.

@konstin konstin closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants