Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv add disregards venv called venv #9269

Open
paveldikov opened this issue Nov 20, 2024 · 0 comments
Open

uv add disregards venv called venv #9269

paveldikov opened this issue Nov 20, 2024 · 0 comments

Comments

@paveldikov
Copy link
Contributor

paveldikov commented Nov 20, 2024

I think the insistence on .venv (with leading dot) is a bit too much. I get that the idea is to install in the project venv and not any old venv, but there should be a bit of give here.

Perhaps the heuristic should be:

  • 'is $VIRTUAL_ENV a subdirectory of dirname pyproject.toml

rather than the current

  • 'is $VIRTUAL_ENV equal to $(dirname pyproject.toml)/.venv

Also, note that .venv vs venv is a somewhat controversial choice, with a bunch of people/systems feeling strongly either way. (FWIW, personally I don't, but I'd rather not have to exhort people to rename their venvs.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant