Use libnotmuch to read notmuch config

[jorsn]

• Default initialize all pointers in Astroid class to avoid segfault in dtor #753 (comment)
• Default initialize all pointers in Astroid class to avoid segfault in dtor #753 (comment)

This would require libnotmuch >= 5.4.

@ibuclaw

In my opinion, this issue is not a priority until after the next release, because it does not fix broken/bad behavior of astroid. The latter is the most important in the short term.

[ibuclaw]

• Default initialize all pointers in Astroid class to avoid segfault in dtor #753 (comment)
• Default initialize all pointers in Astroid class to avoid segfault in dtor #753 (comment)

This would require libnotmuch >= 5.4.

@ibuclaw

In my opinion, this issue is not a priority until after the next release, because it does not fix broken/bad behavior of astroid. The latter is the most important in the short term.

Agreed, I already have a possible patch ready for this.

ibuclaw@a7c8ab5

[jorsn]

Thanks, I'll have a look at this. If it is easy/ready and cleans up code, we might still do it for the new release.

[jorsn]

This could also fix #714.

[ibuclaw]

Thanks, I'll have a look at this. If it is easy/ready and cleans up code, we might still do it for the new release.

I think mostly the tests haven't been properly fixed up, but I've gone through each fail case to make sure it's handled gracefully.

In the astroid config, only the path to the notmuch config is required (no changes here then). This is then passed to the *_open_with_config function to get the rest, rather than doing all parsing on astroid's side.

I don't think I've checked whether the notmuch config can be inferred from the library/environment when missing from astroid.