Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with specutils 2.0 #259

Open
pllim opened this issue Mar 18, 2025 · 1 comment · May be fixed by #260
Open

Compatibility with specutils 2.0 #259

pllim opened this issue Mar 18, 2025 · 1 comment · May be fixed by #260
Assignees

Comments

@pllim
Copy link
Member

pllim commented Mar 18, 2025

specutils 2.0rc1 is out. It is imperative that we leverage the synergy of this package with that package.

From astropy/specutils#1221:

A quick run over at https://github.com/astropy/astropy-integration-testing/ failed for specreduce. Do the tracebacks look familiar to you?

https://github.com/astropy/astropy-integration-testing/actions/runs/13929757409/job/38983646191

Here is a native specreduce run, also failed:

https://github.com/astropy/specreduce/actions/runs/13892729677/job/38983700486

@rosteen said:

Yes, basically it looks like specreduce will need to add spectral_axis_index=disp_axis in the Spectrum creation call in _get_data_from_image (and maybe one or two other places, that's just the first one I looked at). The test images are 10x10, so specutils can't automatically determine which axis is the spectral axis, since both flux axes have the same size as the spectral axis array that's input (specutils no longer assumes that the last axis corresponds to the spectral axis).

@pllim
Copy link
Member Author

pllim commented Mar 18, 2025

I can probably take a stab at this. See #260

@pllim pllim self-assigned this Mar 18, 2025
@pllim pllim linked a pull request Mar 18, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant