Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

Add version check at application startup #1

Open
gridhead opened this issue Oct 9, 2020 · 8 comments
Open

Add version check at application startup #1

gridhead opened this issue Oct 9, 2020 · 8 comments
Labels
good first issue Good for newcomers

Comments

@gridhead
Copy link
Member

gridhead commented Oct 9, 2020

No description provided.

@gridhead gridhead added good first issue Good for newcomers hacktoberfest Contribute to the notion of open-source this October! labels Oct 9, 2020
@SoWrongImRight
Copy link

Is this to check the version of itself or the version of Python?

@gridhead
Copy link
Member Author

gridhead commented Oct 9, 2020

We are supposed to maintain a JSON file in the repo secrets and that is what the executable would be stating on every startup as a version check.

@jocke45
Copy link

jocke45 commented Oct 29, 2020

I'd like to have a go at this. Haven't really read all the code yet though so don't feel bad about not assigning it to me.

@gridhead
Copy link
Member Author

Hi @jocke45. Take your time going through the code. It is easy and you'd certainly be done with it very soon. Once you know about the code, do reach out again and I'll assign it to you. 😄

@jocke45
Copy link

jocke45 commented Oct 29, 2020

Done reading the code 👍
Do I just to print out the version of wisdom-cli after running a command or was it something else that you meant?

WISDOM > version 09102020 (but nicer)
WISDOM > Welcome Joakim, please wait while the results are obtained.
RESULT > SEARCH > ...

We are supposed to maintain a JSON file in the repo secrets and that is what the executable would be stating on every startup as a version check.

So I want to read a json to get the version number ideally, do you have an example/template for it?

@gridhead
Copy link
Member Author

Do I just to print out the version of wisdom-cli after running a command or was it something else that you meant?

No. That can be viewed easily with the --version option.

So I want to read a json to get the version number ideally, do you have an example/template for it?

This issue would take a lot of discussion to decide on how the semantic versioning would be maintained. The JSON would be maintained in this repo and every time, a version check is selected - the application should contact the server to see if there are new versions available or not.

@jocke45
Copy link

jocke45 commented Oct 30, 2020

So this issue is more of a discussion of how to implement a version check at first?

@gridhead
Copy link
Member Author

For now, yes. It would be some time before we actually begin implementing this.

@gridhead gridhead removed the hacktoberfest Contribute to the notion of open-source this October! label Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants