Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

Repetitive Code for printing data to Terminal #26

Open
Sameer-Mann opened this issue Oct 30, 2020 · 6 comments
Open

Repetitive Code for printing data to Terminal #26

Sameer-Mann opened this issue Oct 30, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Sameer-Mann
Copy link
Contributor

Currently everywhere where something needs to be printed "click.echo(click.style("message1")" is being repeated and could be replaced by a simple function increasing readability of code.

@gridhead
Copy link
Member

Certainly we would need that. Would you want to pick this up? @Sameer-Mann

@gridhead gridhead added enhancement New feature or request good first issue Good for newcomers labels Oct 30, 2020
@Sameer-Mann
Copy link
Contributor Author

yes assign it to me

@gridhead gridhead added the hacktoberfest Contribute to the notion of open-source this October! label Oct 30, 2020
@Sameer-Mann
Copy link
Contributor Author

@t0xic0der currently the function "savehtml" does nothing
Screenshot 2020-10-30 at 10 36 27 PM
Is this intentional or does it need to be completed?

@Sameer-Mann
Copy link
Contributor Author

Sameer-Mann commented Oct 30, 2020

@gridhead
Copy link
Member

@t0xic0der currently the function "savehtml" does nothing
Screenshot 2020-10-30 at 10 36 27 PM
Is this intentional or does it need to be completed?

Yes, that is intentional. There's still some work that needs to be done before the section is called complete.

@gridhead
Copy link
Member

Is this way "https://github.com/Sameer-Mann/wisdom-cli/blob/main/main.py" okay?

Looks okay to me. Gotta see if it works just right when you make a PR.

@gridhead gridhead linked a pull request Oct 31, 2020 that will close this issue
@gridhead gridhead removed the hacktoberfest Contribute to the notion of open-source this October! label Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants