Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percent sign % breaks ga tracking #96

Open
pykler opened this issue Jul 7, 2011 · 10 comments
Open

Percent sign % breaks ga tracking #96

pykler opened this issue Jul 7, 2011 · 10 comments

Comments

@pykler
Copy link

pykler commented Jul 7, 2011

The line of code:

_t._gaq.push(['_trackPageview', decodeURI(value)]);

decodeURI does not work if the value had a lone % sign, as far as I can see, value was not previously encoded and therefore should not be decoded

@flablog
Copy link

flablog commented Sep 30, 2011

Hi !

same issue for me. In firefox for example, from a link in a gmail email I click and the #/# becomes #/%23 and jquery.address won't work.
Same issue in a OSX Safari from a Thunderbird client. So It may be useful to catch that inside the jquery plugin directly as different browser have the same issue.
And I cant figure out how to change the hash before .address triggers... and it would be pointless right?

Thanks for that plug by the way. Easy to use and deploy.

@flablog
Copy link

flablog commented Oct 10, 2011

Pykler, did you find any solution for that issue ? :S

@joksnet
Copy link

joksnet commented Oct 19, 2011

Same problem here with crawable activate.

When I send the URL by mail, some webmails will encode the URL. Instead of http://example.com/#!/page will be http://example.com/#%21/page.

The plugin doesn't decode the ! character and the ajax request is not correct.

@kimhallberg
Copy link

same issue here I get http://example.com/#!/%2Fsomething instead of http://example.com/#!/something
Linking works on a static/dynamic tags, but not the ones generated by the data.xml, and I haven't changed anything, downloaded it just a few days ago, and not working.

@kimhallberg
Copy link

Anyone found a solution yet?

@flablog
Copy link

flablog commented Oct 24, 2011

Nop :(

@kimhallberg
Copy link

Anyone tested if it works on 1.5? I haven't had the time to test it out yet, so I don't know if it's fixed.

@joksnet
Copy link

joksnet commented Oct 24, 2011

A quick workaround is set location.hash = decodeURIComponent(location.hash) before the plugin include.

@flablog
Copy link

flablog commented Oct 24, 2011

Hey, that work well for me !
Not so clean (it can be nice to include it in the plugin directly)... but working
Thanks ! :)

@nbergseng
Copy link

Along the same lines of this, adding a space in the path will break the uri on some browsers. I don't want to fully encode the entire string, because then you lose things like slashes. The solution for me has been to regex into uri encoded form spaces and one or two other chars, rather than to use encode/decode uri component.

I'd like to see better encoding on the next version of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants