Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align API with origin native-tls #35

Open
Huzzle opened this issue Aug 1, 2023 · 0 comments
Open

Align API with origin native-tls #35

Huzzle opened this issue Aug 1, 2023 · 0 comments

Comments

@Huzzle
Copy link

Huzzle commented Aug 1, 2023 •
edited
Loading

TlsAcceptor::new accepts a file and a password as parameters. It goes against the constructor in the origin native-tls crate where it accepts Identity. Due to Identity is encapsulated from_pkcs8 method is missed.

I think this crate should extend the origin one, not override it.

Could you align API of both crates one to one? Or add other possibility to use from_pkcs8 method?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Huzzle