Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] asyncapi generate models LANGUAGE FILE command not giving desired output without -o flag #1654

Closed
2 tasks done
Adi-204 opened this issue Feb 8, 2025 · 5 comments · Fixed by #1664
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@Adi-204
Copy link
Contributor

Adi-204 commented Feb 8, 2025

Describe the bug.

The asyncapi generate models LANGUAGE FILE command does not log the generated model code in the terminal when the -o flag is not provided.

Expected behavior

The expected behavior is that, without -o, the generated model code should be printed to stdout, but currently, nothing is being logged.

Screenshots

Image

How to Reproduce

  1. Run the command asyncapi generate models LANGUAGE FILE
  2. It will only display Successfully generated the following models: AnonymousSchema1 and not actual model code.

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@Adi-204 Adi-204 added the bug Something isn't working label Feb 8, 2025
@github-project-automation github-project-automation bot moved this to To Triage in CLI - Kanban Feb 8, 2025
@Adi-204
Copy link
Contributor Author

Adi-204 commented Feb 8, 2025

Waiting for issue approval by maintainers. Please assign me the issue.

@AayushSaini101
Copy link
Collaborator

Waiting for issue approval by maintainers. Please assign me the issue.

can you please research, might be some other commands also have same enhancement ? it would be good to maintain the consistency in across all the commands of the CLI thanks : )

@Adi-204
Copy link
Contributor Author

Adi-204 commented Feb 14, 2025

@AayushSaini101 Sure sir thanks : )

@Adi-204
Copy link
Contributor Author

Adi-204 commented Feb 14, 2025

@AayushSaini101 after research all the commands implementation is right except the asyncapi diff OLD NEW where actually the implementation of -o is missing and the output is always printed in CLI -

Image

I have explain exactly what issue is present in that command here. Can I create PR for this issue for now?

@AayushSaini101
Copy link
Collaborator

here.

@Adi-204 yes, feel free to create a PR thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants