Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling unhandledRejection for support of nodejs version < 15.x.x #234

Closed
imabp opened this issue Feb 18, 2022 · 7 comments
Closed

handling unhandledRejection for support of nodejs version < 15.x.x #234

imabp opened this issue Feb 18, 2022 · 7 comments
Labels
enhancement New feature or request stale

Comments

@imabp
Copy link
Member

imabp commented Feb 18, 2022

With introduction to NodeJS 15 blog
https://developer.ibm.com/blogs/nodejs-15-release-blog/

All unhandled rejections will be treated as strictly as errors , instead of warnings. Hence the process will be closed.

This is directly affecting our cli watcher for nodejs < 15 and nodejs > 15, as mentioned here #220 (comment)

@magicmatatjahu has suggested the following solution to this

process.on('unhandledRejection', (reason, promise) => {
 // throw error and stop process
});```

This issue tries to address the above problem

@imabp imabp added the enhancement New feature or request label Feb 18, 2022
@magicmatatjahu
Copy link
Member

magicmatatjahu commented Feb 18, 2022

NOTE: >=15 versions handle that in proper way, <15 only have a problem.

@imabp imabp changed the title handling unhandledRejection for support of nodejs version >=15 handling unhandledRejection for support of nodejs version <15 Feb 18, 2022
@imabp imabp changed the title handling unhandledRejection for support of nodejs version <15 handling unhandledRejection for support of nodejs version < 15 Feb 18, 2022
@imabp imabp changed the title handling unhandledRejection for support of nodejs version < 15 handling unhandledRejection for support of nodejs version < 15.x.x Feb 18, 2022
@ritik307
Copy link
Contributor

@magicmatatjahu is the issue still up for work? If so I would like to work on this. :)

@imabp
Copy link
Member Author

imabp commented Feb 18, 2022

Oops @ritik307 , I can update you on this...
I am working on it, post the watcher PR #220 ...as this issue has a dependency on it

But if needed help, I would definitely update here. 😊

@ritik307
Copy link
Contributor

Oops @ritik307 , I can update you on this...
I am working on it, post the watcher PR #220 ...as this issue has a dependency on it

But if needed help, I would definitely update here. 😊

Sure no problem 😊

@imabp
Copy link
Member Author

imabp commented Feb 21, 2022

@magicmatatjahu ,just curious, how do we start working on this now as watcher is ready :)
You have any design suggestions?

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 22, 2022
@imabp
Copy link
Member Author

imabp commented Jun 22, 2022

This is already solved ..mr bot 🤭

@imabp imabp closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants