Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate git-vote to get better automation around TSC voting and easy to calculate participation #1093

Closed
derberg opened this issue Mar 11, 2024 · 11 comments · Fixed by #1120
Assignees
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bounty enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Mar 11, 2024

https://github.com/cncf/gitvote is already installed in our organization, for community repo

There is one problem here - I don't think it supports discussions. But also I don't think it is a big problem. We can still use discussions to discuss stuff, and then use PR/issue for final voting, depending on the case.

config for .gitvote.yml that would have to be introduced:

profiles:
  default:
    duration: 2m
    pass_threshold: 51
    periodic_status_check: "1 week"
    allowed_voters:
      teams:
        - tsc_members

outcome should be:

  • we need config as above
  • we need document that describes how things work, commands and all that stuff
  • we need additional workflow that after adding /vote comment, it adds a label to the issue/PR so later it is easier to track record of votes. When /cancel-vote is added, we should remove the label.
  • we should also have a workflow that will add vote-passed or vote-did-not-pass whenever git-vote bot adds related comment
@derberg derberg added enhancement New feature or request area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Mar 11, 2024
@derberg
Copy link
Member Author

derberg commented Mar 11, 2024

workflows should be easy to do as we already have experience with handling in workflow concepts like:

  • react to comment
  • add label

https://github.com/search?q=repo%3Aasyncapi%2F.github%20comment&type=code

@AayushSaini101
Copy link
Contributor

workflows should be easy to do as we already have experience with handling in workflow concepts like:

  • react to comment
  • add label

https://github.com/search?q=repo%3Aasyncapi%2F.github%20comment&type=code

@derberg I am interested in this issue, also have experience in workflow in the past we used in the generator issue thanks asyncapi/generator#538

@aeworxet
Copy link
Contributor

Bounty Issue's service comment

Text labels: bounty/2024-Q2, bounty/medium, bounty/devops
First assignment to third-party contributors: 2024-03-22 00:00:00 UTC+12:00
End Of Life: 2024-08-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

@aeworxet aeworxet moved this to No Assignee in Bounty Program Mar 18, 2024
@AayushSaini101
Copy link
Contributor

AayushSaini101 commented Mar 19, 2024

@derberg I have started working on my own repo for testing AayushSaini101/Vote#1 here is the sample, We just need to add configuration for the allowed users and command.

@derberg
Copy link
Member Author

derberg commented Mar 21, 2024

@AayushSaini101 ok, assigned the issue to you. Please go ahead

@Shurtu-gal
Copy link
Contributor

We can have automation around voting too like changes in CODEOWNERS files can call for voting by tsc_members using this

Furthermore, we can have multiple profiles as well:-

  • TSC_MEMBER voting
  • Community Voting
  • Maintainers Voting

WDYT? @derberg

Also, should we add the profile for the whole organisation or just this repo ?

@aeworxet
Copy link
Contributor

Bounty Issue's Timeline

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Medium 2024-03-21 2024-04-01 2024-05-10 2024-04-12 2024-04-26 2024-05-10
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@aeworxet aeworxet moved this from No Assignee to In Progress in Bounty Program Mar 21, 2024
@derberg
Copy link
Member Author

derberg commented Mar 25, 2024

@Shurtu-gal at the moment we officially have only something like TSC voting

also, codeowners changes are not a subject for voting for TSC but only repo maintainers decision

@derberg
Copy link
Member Author

derberg commented Apr 9, 2024

we still need to get #1155 merged first

@derberg
Copy link
Member Author

derberg commented Apr 25, 2024

@aeworxet fyi bounty completed

@aeworxet
Copy link
Contributor

Bounty Issue Completed 🎉

@AayushSaini101, please go to the AsyncAPI page on Open Collective and submit an invoice for USD 200.00 with the expense title Bounty community#1093, tag bounty, and full URL of this Bounty Issue in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bounty enhancement New feature or request
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants