Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update release configuration #440

Merged
merged 5 commits into from
Aug 31, 2023
Merged

chore: update release configuration #440

merged 5 commits into from
Aug 31, 2023

Conversation

jonaslagoni
Copy link
Member

Description
This PR updates the release configuration to use the newest CI system.

Related issue(s)
Fixes #429

@jonaslagoni
Copy link
Member Author

@fmvilas @magicmatatjahu @derberg one of you have to add the correct tags as well :)

@derberg
Copy link
Member

derberg commented Aug 31, 2023

@jonaslagoni tags added

but this Pr do not fix the related issue, there is still one custom workflow that needs a fix - https://github.com/asyncapi/html-template/blob/master/.github/workflows/pr-testing-with-generator.yml (do you want to fix it in this PR or leave it for others?)

@jonaslagoni
Copy link
Member Author

Ill fix it here

@derberg
Copy link
Member

derberg commented Aug 31, 2023

thanks, can you make sure we no longer use generator directly npm i @asyncapi/generator but AsyncAPI CLI through npx?

fmvilas
fmvilas previously approved these changes Aug 31, 2023
View reviewed changes
@jonaslagoni
Copy link
Member Author

thanks, can you make sure we no longer use generator directly npm i @asyncapi/generator but AsyncAPI CLI through npx?

Done 👍

@jonaslagoni jonaslagoni mentioned this pull request Aug 31, 2023
Merged
derberg
derberg requested changes Aug 31, 2023
View reviewed changes
.github/workflows/pr-testing-with-generator.yml Outdated Show resolved Hide resolved
.github/workflows/pr-testing-with-generator.yml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@derberg
Copy link
Member

derberg commented Aug 31, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 55afc3c into asyncapi:master Aug 31, 2023
12 checks passed
@jonaslagoni jonaslagoni deleted the update_release_flow branch August 31, 2023 10:56
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.28.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas left review comments

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need for urgent changes in GitHub Actions automation
4 participants
@jonaslagoni @derberg @asyncapi-bot @fmvilas