-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add community docs bucket #1261
docs: add community docs bucket #1261
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1261--asyncapi-website.netlify.app/ |
red feels negative or a reminder to stop something 🛑 🚨 😄😂😂 I would use another color... hmm... what do you think about orange 🍊 !? @magicmatatjahu |
oooh, I was surprised to see that it has higher priority than the reference bucket (5 -> 6)... but I like it! it seems good to not have it be the last content bucket because then it also comes across as being "less important" than the other content buckets 😄 |
components/docs/DocsCards.js
Outdated
@@ -37,13 +38,20 @@ const cards = [ | |||
className: 'bg-primary-200', | |||
Icon: IconGuide, | |||
}, | |||
{ | |||
title: 'Community', | |||
description: 'Our Community section documents the community guidelines and resources.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'Our Community section documents the community guidelines and resources.', | |
description: 'Our Community section documents **community** _processes_, **contribution guidelines**, and **resources**.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can we add this styling in this js file? 😄😬😬😬😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but what about other buckets and theirs description? Should we also bold some parts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good point... maybe we shouldn't 🧐
@alequetzalli Ok, I changed color to the orange, WDYT? |
@derberg I need approve :) |
I don't recall we had a final decision if |
@derberg Then discuss that with @alequetzalli 😄 |
@alequetzalli we need to go further here, remember -> https://github.com/orgs/asyncapi/discussions/525#discussioncomment-4224105 😄 |
ok then, I guess we can go with this one, except the fact that
or
|
I prefer the first option, but I'm I'm also struggling with the idea of the community content bucket being the last one 🤔 I'm not sure if I'm overthinking it but would having the community content bucket last make it seem like it's the least important topic? |
It might, but logically it makes sense imho. 2nd option logically also makes sense as |
Yeah totally... I still vote for option 1 tho because it's more likely a better user experience to have tools higher up if tools docs receive more visits than community docs. It would probably be a good idea to look at the stats currently in analytics, and if tools docs are getting the majority of visits, then we shouldn't put it at the bottom where users will need to scroll all the way to find it in the left-hand navigation. |
moving community content bucket to last place
Can we move this PR forward @akshatnema? 🤔 😄 I am hoping we don't wait for Lukasz to finish vacation because this has been lagging for too long already. Since I fixed it so that |
yo @akshatnema, pingy pongo 😄 |
/rtm |
Description
Add community docs bucket:
@alequetzalli Please fix my description about new bucket 😆
Related issue(s)
Part of #1240