Skip to content

Does not stop CI build if Could not import error #35

@AndyOGo

Description

@AndyOGo

I just realised that this does not properly throw or setting proper exit codes with process.exitCode if an import fails. Instead it just logs to the console:

Error: Could not import `module-does-not-exist` from any of the following locations:
  /frontend-lib/src/scss/module-does-not-exist.scss
  /frontend-lib/src/scss/module-does-not-exist.sass
  /frontend-lib/src/scss/_module-does-not-exist.scss
  /frontend-lib/src/scss/_module-does-not-exist.sass
  /frontend-lib/node_modules/@axa-ch/style-guide/scss/module-does-not-exist.scss
  /frontend-lib/node_modules/@axa-ch/style-guide/scss/module-does-not-exist.sass
  /frontend-lib/node_modules/@axa-ch/style-guide/scss/_module-does-not-exist.scss
  /frontend-lib/node_modules/@axa-ch/style-guide/scss/_module-does-not-exist.sass

This false behaivior is caused at the following lines:

Further more the done callback in above code blocks does not use first-error arguments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions