-
Notifications
You must be signed in to change notification settings - Fork 20
Closed
axa-ch/node-sass-import-once
#1Description
I just realised that this does not properly throw
or setting proper exit codes with process.exitCode
if an import fails. Instead it just logs to the console:
Error: Could not import `module-does-not-exist` from any of the following locations:
/frontend-lib/src/scss/module-does-not-exist.scss
/frontend-lib/src/scss/module-does-not-exist.sass
/frontend-lib/src/scss/_module-does-not-exist.scss
/frontend-lib/src/scss/_module-does-not-exist.sass
/frontend-lib/node_modules/@axa-ch/style-guide/scss/module-does-not-exist.scss
/frontend-lib/node_modules/@axa-ch/style-guide/scss/module-does-not-exist.sass
/frontend-lib/node_modules/@axa-ch/style-guide/scss/_module-does-not-exist.scss
/frontend-lib/node_modules/@axa-ch/style-guide/scss/_module-does-not-exist.sass
This false behaivior is caused at the following lines:
- https://github.com/at-import/node-sass-import-once/blob/master/index.js#L310-L313
- https://github.com/at-import/node-sass-import-once/blob/master/index.js#L321-L324
Further more the done
callback in above code blocks does not use first-error arguments.
Metadata
Metadata
Assignees
Labels
No labels