Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual machine templates count to common report "trailer", metrics? #928

Open
atc0005 opened this issue Aug 25, 2023 · 1 comment
Open
Assignees
Labels
output/extended Long Service Output (aka, "extended" or "detailed") output/perfdata Service Perf Data (aka, "performance data") question Further information is requested template virtual machine
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Aug 25, 2023

Overview

The report "trailer" currently emits details similar to this for plugins which offer filtering of virtual machines, folders, etc.:

* vSphere environment: https://vc1.example.com:443/sdk
* Plugin User Agent: check-vmware/v0.35.0
* VMs evaluated: 491 of 492
* Powered off VMs evaluated: true
* Specified VMs to exclude (1): [vm1]
* Specified Folders to explicitly include (0): []
* Specified Folders to explicitly exclude (0): []
* Folders evaluated: 0 of 144
* Specified Resource Pools to explicitly include (0): []
* Specified Resource Pools to explicitly exclude (0): []
* Resource Pools evaluated (30 of 30): [rp1, rp2, ..., rp29]

Would it be useful to also include a line similar to the following?

...
* VM templates evaluated: X of Y

X in this case would usually be 0, Y would be whatever number of templates are in the inventory.

I initially thought "no" and am still leaning this direction as:

  • the trailer is already fairly dense and likely to grow based on other filtering options included in the future
  • no plugins currently provided by this project include/exclude VMs based on whether they're a template vs a "normal" VM

The same goes for a perfdata metric.

Filing this for further consideration, but as of now I think it's better to hold off listing those details (trailer, metric) until #879 is implemented.

References

@atc0005 atc0005 added question Further information is requested virtual machine output/extended Long Service Output (aka, "extended" or "detailed") output/perfdata Service Perf Data (aka, "performance data") template labels Aug 25, 2023
@atc0005 atc0005 added this to the Future milestone Aug 25, 2023
@atc0005 atc0005 self-assigned this Aug 25, 2023
@atc0005
Copy link
Owner Author

atc0005 commented Aug 25, 2023

As the OP indicates, this was something I had prototyped for #809 but ultimately decided against it for two reasons:

  • The implementation for gathering the details was too slow
  • I could not find a legitimate/useful reason for emitting the number of templates in the inventory

The first was the primary reason as I believe I could have made listing the template count work without being too dense (the scope of this GH issue).

I ultimately could not justify the change as it increased the runtime of applicable plugins too much. With some refactoring work (see also #926) this cost may not be as significant as it seemed during initial prototyping work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output/extended Long Service Output (aka, "extended" or "detailed") output/perfdata Service Perf Data (aka, "performance data") question Further information is requested template virtual machine
Projects
None yet
Development

No branches or pull requests

1 participant