fix more linting

Author: kwibus

classes/claim/address.php

@@ -29,7 +29,6 @@
  * @link https://openid.net/specs/openid-connect-core-1_0.html#AddressClaim
  */
 class address implements claim {
-
     /**
      * Get addres claim.
      * @param array $user core_user user user want the address claim from

classes/claim/claim.php

@@ -29,7 +29,6 @@
  * @link https://openid.net/specs/openid-connect-core-1_0.html#Claims
  */
 interface claim {
-
     // TODO why array not the object.
 
     /**

classes/claim/email.php

@@ -29,7 +29,6 @@
  * @link https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
  */
 class email implements claim {
-
     /**
      * Get email claim.
      * @param array $user core_user user user want the email claim from

classes/claim/phone.php

@@ -29,7 +29,6 @@
  * @link https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
  */
 class phone implements claim {
-
     /**
      * Get phone claim.
      * @param array $user core_user want the address claim from

classes/claim/profile.php

@@ -30,7 +30,6 @@
  * @link https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
  */
 class profile implements claim {
-
     /**
      * Get addres claim.
      * @param array $user core_user want the address claim from
@@ -46,7 +45,7 @@ public function claim($user) {
             'middle_name' => $user->middlename,
             'nickname' => $user->alternatename,
             'preferred_username' => $user->username,
-            'profile' => $CFG->wwwroot."/user/profile.php?id=".$user->id,
+            'profile' => $CFG->wwwroot . "/user/profile.php?id=" . $user->id,
             'picture' => $user->picture ? $userpicture->get_url($PAGE)->raw_out() : null,
             // NOTE moodle timezone is 99 if you set timezone is same as server.
             'zoneinfo' => $user->timezone == '99' ? date_default_timezone_get() : $user->timezone,

classes/event/user_granted.php

@@ -28,7 +28,6 @@
  * Event that is triggered when user authenticated succesfull with this oauth plugin
  */
 class user_granted extends \core\event\base {
-
     /**
      * Returns description of what happened.
      *
@@ -83,5 +82,4 @@ protected function validate_data() {
             throw new \coding_exception('The property scope must be set.');
         }
     }
-
 }

classes/event/user_not_granted.php

@@ -28,7 +28,6 @@
  * Event that is triggered when user is NOT succesfull authenticated succesfull with this oauth plugin
  */
 class user_not_granted extends user_granted {
-
     /**
      * Returns description of what happened.
      *

classes/form/authorize.php

@@ -29,7 +29,6 @@
  * Form that request the use if he the client should be authorize, to get information specified by the requested scope.
  */
 class authorize extends moodleform {
-
     /**
      * Defined fields for the authorize form.
      */
@@ -38,14 +37,14 @@ public function definition() {
 
         $clientid = required_param('client_id', PARAM_RAW);
 
-        $text = get_string('auth_question', 'local_oauth', $clientid).'<br />';
+        $text = get_string('auth_question', 'local_oauth', $clientid) . '<br />';
         $mform->addElement('html', $text);
         $scope = optional_param('scope', false, PARAM_TEXT);
         if (!empty($scope)) {
             $scopes = explode(' ', $scope);
-            $text = get_string('auth_question_desc', 'local_oauth').'<ul>';
+            $text = get_string('auth_question_desc', 'local_oauth') . '<ul>';
             foreach ($scopes as $scope) {
-                $text .= '<li>'.get_string('scope_'.$scope, 'local_oauth').'</li>';
+                $text .= '<li>' . get_string('scope_' . $scope, 'local_oauth') . '</li>';
             }
             $text .= '</ul>';
         } else {

classes/form/edit_client.php

@@ -34,7 +34,6 @@
  * Form for client options
  */
 class edit_client extends moodleform {
-
     /**
      * Define the fields of the form
      */
@@ -68,7 +67,7 @@ public function definition() {
         $bform->setExpanded('othersettings', false);
         $grantoptions = $server->getGrantTypes();
         foreach ($grantoptions as $key => $value) {
-            $grantoptions[$key] = $key . ": " . get_string($key."_explanation", "local_oauth");
+            $grantoptions[$key] = $key . ": " . get_string($key . "_explanation", "local_oauth");
         }
         // TODO Consider replacing this with checkbox for granttypes.
         $select = $bform->addElement('select', 'granttypes', get_string('grant_types', 'local_oauth'), $grantoptions);
@@ -98,7 +97,6 @@ public function definition() {
         $bform->setType('noconfirmation', PARAM_BOOL);
 
         $this->add_action_buttons();
-
     }
 
     /**

classes/privacy/provider.php

@@ -37,10 +37,9 @@
  *
  */
 class provider implements
+    \core_privacy\local\request\core_userlist_provider,
     \core_privacy\local\metadata\provider,
-    \core_privacy\local\request\plugin\provider,
-    \core_privacy\local\request\core_userlist_provider {
-
+    \core_privacy\local\request\plugin\provider {
     /**
      * Return the fields which contain personal data.
      *
@@ -71,7 +70,8 @@ public static function get_metadata(collection $collection): collection {
                 'expires' => 'privacy:metadata:local_oauth:refresh_tokens:expires',
                 'scope' => 'privacy:metadata:local_oauth:refresh_tokens:scope',
             ],
-            'privacy:metadata:local_oauth:refresh_tokens:tableexplanation');
+            'privacy:metadata:local_oauth:refresh_tokens:tableexplanation'
+        );
 
         $collection->add_database_table(
             'local_oauth_auth_codes',
@@ -85,9 +85,11 @@ public static function get_metadata(collection $collection): collection {
                 'scope' => 'privacy:metadata:local_oauth:auth_codes:scope',
                 'id_token' => 'privacy:metadata:local_oauth:auth_codes:id_token',
             ],
-            'privacy:metadata:local_oauth:auth_codes:tableexplanation');
+            'privacy:metadata:local_oauth:auth_codes:tableexplanation'
+        );
 
-        $collection->add_database_table('local_oauth_access_tokens',
+        $collection->add_database_table(
+            'local_oauth_access_tokens',
             [
                 'id' => 'privacy:metadata:local_oauth:access_tokens:id',
                 'access_token' => 'privacy:metadata:local_oauth:access_tokens:access_token',
@@ -96,7 +98,8 @@ public static function get_metadata(collection $collection): collection {
                 'expires' => 'privacy:metadata:local_oauth:access_tokens:expires',
                 'scope' => 'privacy:metadata:local_oauth:access_tokens:scope',
             ],
-            'privacy:metadata:local_oauth:access_tokens:tableexplanation');
+            'privacy:metadata:local_oauth:access_tokens:tableexplanation'
+        );
 
         $collection->add_external_location_link(
             'oauth_client',
@@ -116,7 +119,9 @@ public static function get_metadata(collection $collection): collection {
                 'locality ' => 'privacy:metadata:oauth_client:locality',
                 'country' => 'privacy:metadata:oauth_client:country',
                 'enrolments' => 'privacy:metadata:oauth_client:enrolments',
-            ], 'privacy:metadata:oauth_client');
+            ],
+            'privacy:metadata:oauth_client'
+        );
 
         // Plugin also access user and enrolment data but does not store or modify it.
         // So we dont have to specify that.
@@ -134,7 +139,6 @@ public static function get_contexts_for_userid(int $userid): contextlist {
 
         $contextlist = new \core_privacy\local\request\contextlist();
         return $contextlist->add_user_context($userid);
-
     }
 
     /**
@@ -181,7 +185,7 @@ public static function export_user_data(approved_contextlist $contextlist) {
         $userauthscopes = $DB->get_records('local_oauth_user_auth_scopes', ['user_id' => $user->id]);
         foreach ($userauthscopes as $scope) {
             $scope->user_id = transform::user($scope->user_id);
-            writer::with_context($context)->export_data( array_merge($subcontext, [
+            writer::with_context($context)->export_data(array_merge($subcontext, [
                 $scope->client_id,
                 $scope->scope,
                 get_string('privacy:metadata:local_oauth:auth_scopes', 'local_oauth'),
@@ -217,7 +221,7 @@ public static function export_user_data(approved_contextlist $contextlist) {
             $token->user_id = transform::user($token->user_id);
             $token->expires = transform::datetime($token->expires);
             $token->access_token = $notexportedstr;
-            writer::with_context($context)->export_data( array_merge($subcontext, [
+            writer::with_context($context)->export_data(array_merge($subcontext, [
                 $token->client_id,
                 $token->scope,
                 get_string('privacy:metadata:local_oauth:access_tokens', 'local_oauth'),
@@ -283,8 +287,5 @@ private static function delete_user(int $userid) {
         $DB->delete_records('local_oauth_refresh_tokens', ['user_id' => $userid]);
         $DB->delete_records('local_oauth_auth_codes', ['user_id' => $userid]);
         $DB->delete_records('local_oauth_access_tokens', ['user_id' => $userid]);
-
     }
-
 }
-