-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not totally fair #2
Comments
Also, the C# example uses |
Yep, IMHO Go, C# and Haskell examples are close (task-based), so are Erlang and Akka ones (actor-based). There's a PR with Future-based Scala example, need to measure that :) |
The Node example using Promises also puts it into an entirely different category. It would be better to use the async module for Node or use the Cluster feature (although that creates an entirely new process). |
Yeah, Node version is not concurrent at all. If we allow for that, all examples would be quite different and probably perform better since the actual "computation" is a no-op. |
As for Node's asynchrony: Note that you're actually benchmarking a Promise library, not native promises. |
@ochrons Totally agree. Just because you call something |
I think the README should be updated to remove the word actors. C# Tasks are not actors, which makes the following sentence inaccurate and misleading: "Creates an actor (goroutine, whatever), which spawns 10 new actors, each of them spawns 10 more actors, etc. until one million actors are created on the final level." Actors and async tasks are not the same thing. Something like actors do exist in the .NET world in the Orleans framework, but they are different than what's found in Akka or Erlang. For more info on Orleans' "Virtual Actors": https://github.com/akka/akka-meta/blob/master/ComparisonWithOrleans.md http://daprlabs.com/blog/blog/2014/04/03/microsoft-orleans-why-its-cool-useful/ For that matter, Goroutines and Elixir/Erlang processes are also a bit different from each other Anyway, like others have said, it doesn't make sense to compare Tasks/Futures/Promises/etc. with Actors/Virtual Actors/Goroutines/Erlang processes, as they aren't really doing the same things. |
Add stack hidden files to .gitignore
One another thing I noticed was the delay in Akka test runs were mainly due to GC. I increased the JVM memory and ran the tests again and I got better performance. @atemerev, can you please the memory consumed by each implementation so that we understand we were not too unfair with JVM. |
Fix two problems, atemerev#1 is the original code would generate 'Size' of hung processes, since when Size becomes to 1, then still spawn the process_sum process, it is problematic; atemerev#2 is to avoid the compile time warning for 'X' variable not use.
I think the test may have some issues:
Good job anyway, []s, Ricardo Mello
The text was updated successfully, but these errors were encountered: