Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-url: entering url without http(s):// prefix no longer works v3.11.3 #3349

Closed
fictitiousexistence opened this issue Feb 26, 2024 · 1 comment · Fixed by #3351
Closed
Assignees
Labels
3-series Related to releases whose major version is 3. bug

Comments

@fictitiousexistence
Copy link

Describe the bug
Typing fqdn in set-url (github.com / google.com/etc) without http(s):// prefix no longer takes you to the direct url, instead shows search results.

Issue occurs in Nyxt 3.11.3. Works properly in ≤3.11.2

Precise recipe to reproduce the issue

  1. Run set url command (o in vi mode)
  2. type github.com > enter
  3. Takes you to search results instead of https://github.com

Information

  • OS name+version:
    gentoo
  • Graphics card and driver:
  • Desktop environment / Window manager name+version:
    dwl
  • How you installed Nyxt (Guix pack, package manager, build from source):
    source
  • Information from show-system-information:
    Nyxt version: 3.11.3
    Renderer: GI-GTK
    Operating system kernel: Linux 6.7.6-gentoo
    Lisp implementation: SBCL 2.4.1 (Dynamic space size: 3221225472)
    Features: (:NYXT-GI-GTK :NYXT-GTK :NYXT-GI-GTK :NYXT-GTK :NYXT-3.11 :NYXT-3 :NYXT-3.11.3
    :CLIPBOARD-CONTENT-METHOD :SWANK :SLYNK :PLUMP-UTF-32 :PARENSCRIPT :NSYMBOLS
    :FSET-EXT-STRINGS :SBCL+SAFE-STANDARD-READTABLE :NAMED-READTABLES :GLOBAL-VARS
    :CL-FAD :LPARALLEL :21BIT-CHARS :CUSTOM-HASH-TABLE-NATIVE :CL-PPCRE-UNICODE
    :CL-UNICODE :CL-JSON-DOUBLE-FLOAT-IS-SUBSUMED
    :CL-JSON-SINGLE-FLOAT-IS-SUBSUMED :CHUNGA :FLEXI-STREAMS :CL-PPCRE :WEBKIT2
    :WEBKIT-2.42.5 :WEBKIT-2.42 :WEBKIT-2 :WEBKIT2-CORS-ALLOWLIST
    :WEBKIT2-PASTE-PLAINTEXT :WEBKIT2-TRACKING :WEBKIT2-MUTE :WEBKIT2-EMOJI
    :WEBKIT2-MEDIA :WEBKIT2-SANDBOXING :GTK-3-22 :GTK-3-20 :GTK-3-18 :GTK-3-16
    :GTK-3-14 :GTK-3-12 :GTK-3-10 :GTK-3-8 :GTK-3-6 :GTK-3-4 :GTK :GDK-3-22
    :GDK-3-20 :GDK-3-18 :GDK-3-16 :GDK-3-14 :GDK-3-12 :GDK-3-10 :GDK-3-8 :GDK-3-6
    :GDK-3-4 :CAIRO-1-10 :CAIRO-1-12 :GDK-PIXBUF :CLOSER-MOP :GLIB-2-30 :GLIB-2-32
    :GLIB-2-34 :GLIB-2-36 :GLIB-2-38 :GLIB-2-40 :GLIB-2-42 :GLIB-2-44 :GLIB-2-46
    :GLIB-2-48 :GLIB-2-50 :GLIB-2-52 :GLIB-2-54 :GLIB-2-56 :GLIB-2-58 :GLIB
    :BORDEAUX-THREADS :LPARALLEL.WITH-CLTL2 :LPARALLEL.WITH-CAS
    :LPARALLEL.WITH-STEALING-SCHEDULER :SPLIT-SEQUENCE
    CFFI-FEATURES:FLAT-NAMESPACE CFFI-FEATURES:X86-64 CFFI-FEATURES:UNIX :CFFI
    CFFI-SYS::FLAT-NAMESPACE ALEXANDRIA::SEQUENCE-EMPTYP :FAST-IO-SV :FAST-IO
    :CL-JSON-CLOS :CL-JSON :SBCL-USES-SB-ROTATE-BYTE CHIPZ-SYSTEM:GRAY-STREAMS
    :THREAD-SUPPORT :ASDF3.3 :ASDF3.2 :ASDF3.1 :ASDF3 :ASDF2 :ASDF :OS-UNIX
    :NON-BASE-CHARS-EXIST-P :ASDF-UNICODE :ARENA-ALLOCATOR :X86-64 :GENCGC :64-BIT
    :ANSI-CL :COMMON-LISP :ELF :IEEE-FLOATING-POINT :LINUX :LITTLE-ENDIAN
    :PACKAGE-LOCAL-NICKNAMES :SB-CORE-COMPRESSION :SB-LDB :SB-PACKAGE-LOCKS
    :SB-THREAD :SB-UNICODE :SBCL :UNIX)
@aadcg
Copy link
Member

aadcg commented Feb 26, 2024

Thanks for the bug report @fictitiousexistence.

The regression was introduced in #3344. A deep refactor of set-url is required.

@aadcg aadcg added the bug label Feb 26, 2024
@aadcg aadcg self-assigned this Feb 26, 2024
@aadcg aadcg added the 3-series Related to releases whose major version is 3. label Feb 26, 2024
aadcg added a commit that referenced this issue Feb 29, 2024
aadcg added a commit that referenced this issue Feb 29, 2024
aadcg added a commit that referenced this issue Feb 29, 2024
@aadcg aadcg mentioned this issue Feb 29, 2024
5 tasks
aadcg added a commit that referenced this issue Mar 1, 2024
aadcg added a commit that referenced this issue Mar 1, 2024
Improves responsiveness and accuracy when invoking the set-url command.

Fixes #3349.

See commit 36589e3.
aadcg added a commit that referenced this issue Mar 1, 2024
Improves responsiveness and accuracy when invoking the set-url command.

Fixes #3349.

See commit 36589e3.
@aadcg aadcg closed this as completed in 8b00a2f Mar 1, 2024
aadcg added a commit that referenced this issue Mar 4, 2024
Improves responsiveness and accuracy when invoking the set-url command.

Fixes #3349.

See commit 36589e3.
@aadcg aadcg mentioned this issue Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-series Related to releases whose major version is 3. bug
Development

Successfully merging a pull request may close this issue.

2 participants