Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign interface of ffi-window-fullscreen and ffi-window-maximize #3439

Open
aadcg opened this issue Jul 25, 2024 · 1 comment
Open

Foreign interface of ffi-window-fullscreen and ffi-window-maximize #3439

aadcg opened this issue Jul 25, 2024 · 1 comment
Assignees
Labels
4-series Related to releases whose major version is 4. ffi Renderer-specific quirks.

Comments

@aadcg
Copy link
Member

aadcg commented Jul 25, 2024

In the context of #3435, I noticed that ffi-window-{un,}maximize could be greatly simplified. Instead of defining two generics, there could be a single one that gets the maximized state of the window and a setf method that mutates it.

The same reasoning holds for ffi-window-fullscreen.

To get the fullscreen state:

(gdk:gdk-window-get-state (gtk:gtk-widget-window (nyxt/renderer/gtk::gtk-object window)))

To get the maximized state (either as above or):

(gtk:gtk-window-is-maximized (nyxt/renderer/gtk::gtk-object window))

@aadcg aadcg added ffi Renderer-specific quirks. wontfix labels Jul 25, 2024
@aadcg aadcg self-assigned this Jul 25, 2024
@aadcg aadcg removed the wontfix label Jul 25, 2024
@aadcg
Copy link
Member Author

aadcg commented Jul 25, 2024

I believe this will greatly simplify the architecture. I find it extremely odd that this strategy wasn't taken from day 1.

@aadcg aadcg added the 4-series Related to releases whose major version is 4. label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-series Related to releases whose major version is 4. ffi Renderer-specific quirks.
Development

No branches or pull requests

1 participant