Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul the %current-suggestion API #34

Open
aartaka opened this issue Oct 25, 2023 · 0 comments
Open

Overhaul the %current-suggestion API #34

aartaka opened this issue Oct 25, 2023 · 0 comments

Comments

@aartaka
Copy link
Contributor

aartaka commented Oct 25, 2023

One thing that I'd change before 3.0 is %current-suggestion. It's numbers and offsets, and it's a really inconsistent API, so making current suggestion to actually be a suggestion instead and indexing based on source contents. eq list search is cheap, mental juggling to work with indices is expensive.

Originally posted by @aartaka in #29 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aartaka