Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MY05 and SB06 PSDs #280

Open
erikssonpatrick opened this issue Dec 11, 2020 · 0 comments
Open

MY05 and SB06 PSDs #280

erikssonpatrick opened this issue Dec 11, 2020 · 0 comments
Assignees
@m-brath

Comments

@erikssonpatrick
Copy link
Contributor

Sice this morning this test

controlfiles/artscomponents/psd/TestPsds.arts

performs basic testing of some PSDs. I considered to include MY05 and SB06 but did not see how to apply the test on these PSDs.

Suggestion 1: Let the two psd methods output scat_species_a and scat_species_b. As I understand it, these two variables are basically set as internal varaibles. If these varaibles are output, it should be possible to test them following the pattern of the tests already in TestPsds.arts.

Suggestion 2: I think we discussed that there is a duplication of modified gamma code. Could MY05 and SB06 be changed to use the more general MG functions?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-brath m-brath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikssonpatrick @m-brath