Adding syntax highlighting support for Liquid tags

[fusion809]

Hi,

I use this package quite frequently when writing posts in my Jekyll site (The Hornery — source) and it would help big time if this package had syntax-highlighting and autocompletion support for Liquid tags. If it helps, there is a language-liquid package available for Atom, it has syntax-highlighting support for HTML files with Liquid tags in it.

Thanks for your time,
Brenton

[burodepeper]

I think this is best solved by adding markdown files to the filetypes recognized by the language-liquid package (see: https://github.com/kieranmasterton/language-liquid/blob/master/grammars/html%20(liquid).cson#L1-L4). This way language-liquid can inject its functionality into other grammars. (cc @kieranmasterton)

Another solution would be to include language-liquid as part of language-gfm (this is how I support html in my language-markdown package), but I'm not sure if that gives any problems for people that don't have the liquid package installed.

[fusion809]

@burodepeper Ah, I just tried that and it failed. See instead the GFM syntax highlighting was removed entirely from the md file I was editing and language-liquid was used in its place.

[burodepeper]

@fusion809 Ah yes, you are probably right; of source it only uses a single grammar at the time. My bad.

It shouldn't be too difficult to add it similar to this: https://github.com/burodepeper/language-markdown/blob/master/grammars/language-markdown.json#L1500-L1506
Do you have experience with this? Otherwise I'll add it to language-markdown and then they/you can copy my approach from there.

[fusion809]

Na I'm afraid my knowledge of programming is limited. So that would be a big help, thanks.

[burodepeper]

No problem. Could you create an issue over here and supply me with some liquid content so I can test if it works?

[fusion809]

Shall do.

[fusion809]

@burodepeper Thanks, it's just is there anyway to translate your language-markdown changes into config.cson changes to get language-gfm to use language-liquid syntax highlighting for Liquid tags? Your package is pretty good, but what can I say I'm a language-gfm fan.

[puranjayjain]

@burodepeper I have got a list of snippets related to liquid and would like to add snippets for them. where should I send the PR?

[burodepeper]

@puranjayjain If they're purely related to liquid, I'd say send the PR to https://github.com/kieranmasterton/language-liquid

[burodepeper]

@fusion809 You can create a PR that adds this little bit to the language-gfm grammar. Not literally btw, the grammar only needs to include the text.html.liquid grammar and you're set.

[puranjayjain]

@burodepeper thanks but that repository seems to be dead as there is no update for the past 11 months, some issues and PRs are still open. What can be done about that? Any other suggestions or help would be appriciated

[burodepeper]

@puranjayjain Have you tried contacting the maintainer for the possibility of transferring ownership to yourself? According to the package.json the code is released under the MIT license, so if @kieranmasterton (ping, anyone home?) remains unresponsive, you could fork the project, and it release it as a new package.