Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Update status message should not count disabled packages #956

Open
KSXGitHub opened this issue May 25, 2017 · 6 comments · May be fixed by #1005
Open

Update status message should not count disabled packages #956

KSXGitHub opened this issue May 25, 2017 · 6 comments · May be fixed by #1005

Comments

@KSXGitHub
Copy link

Moved from #955

Disabled packages should not be counted ((N) Updates message at the bottom-right corner)

@JonatanPaalsson
Copy link

Hey, I'm a new developer trying to resolve this issue and I have some questions. I've been looking at two different types of solutions and I wanted to ask here to see what you think.

  1. If the disabled packages are not counted in the package-updates-status-view then it should resolve this issue with some work.
  2. The other solution is by not adding disabled packages to updatablePackagesinside package-manager this would result in that you only see your active packages in the Available Updates panel.

Do you want to see that disabled packages have updates? Do we want to update disabled packages when pressing update all?

@KSXGitHub
Copy link
Author

KSXGitHub commented Sep 29, 2017

@JonatanPaalsson

Do you want to see that disabled packages have updates?

Yes, but not as visible as enabled packages. Disabled packages should be hidden behind an expand button.

Do we want to update disabled packages when pressing update all?

Normally, "Update All" will only update enabled packages, unless user click the expand button, "Update All" will update all.

@JonatanPaalsson
Copy link

I just made a pull request to fix this. It does not have any specs yet, but other than that, I think it will solve this bug.

@JonatanPaalsson
Copy link

Normally, "Update All" will only update enabled packages, unless user click the expand button, "Update All" will update all.

Maybe an "Update Active Packages"-button could be added as a separate feature?

@KSXGitHub
Copy link
Author

@JonatanPaalsson makes sense

@JonatanPaalsson
Copy link

@KSXGitHub I'd be happy to give it a shot if new issue is created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants