-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promptly seems outdated #367
Comments
Goot catch. enquirer also provides a far nicer UI. |
I started using |
Not yet pushed, or do you really mean |
Yeah, |
heh - how could I miss that :-) |
|
You can wrap around it using an Option if you would like |
Seems like promptly is being maintained again, last update 9 months ago. I started a branch with dialoguer some time ago, which seems fine, but I have too many other things that take priority over this issue. Anyone reading this: feel free to pick it up! |
...and more than a year later the promptly project is still silent :-( I am no longer able to build atomic-server using crates in Debian: promptly depends on outdated rustyline 9, and even if "cheating" and embedding local copy of that (which means security tracking for that component is severely hampered), that depends on outdated nix 0.23 which could be patched to use Debian-maintained nix up until 0.26, but now fails to build with nix 0.27. I will try fumble with your preliminary patch for switching away from promptly, but doubt that my Rust skills are sufficient, and in that case I may have to put on hold my work on getting Atomic server packaged officially for Debian, which is quite frustrating. |
I'll try dialoguer again! |
Blocked: console-rs/dialoguer#186 |
I have been fighting this since my previous post here (module a bit of sleep), and possibly have a patch very soon (compiles but I haven't tested in a console yet). |
My patch is here |
...and here's my attempt at refining to do validation more integrated (with one nit commented out that I couldn't figure out). Now I am waiting for my slow compliation to complete, so I can actually test if it works at all (my system is not tuned for development but for packaging, so it is cumbersome for me to do iterative non-optimized builds). |
Hey @jonassmedegaard thanks for the patches! Did the tests succeed? I tried applying the patches locally but it seems to fail. Could you try to rebase onto develop and open a PR? I tried at #377 some time ago but failed |
My patch applies cleanly to HEAD of your master branch. |
promptly
hasn't seen an update in 2 years, and depends on old duplicate branches of some libraries.Perhaps sensible to switch to another library, e.g. enquirer?
The text was updated successfully, but these errors were encountered: