Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promptly seems outdated #367

Open
jonassmedegaard opened this issue Apr 3, 2022 · 16 comments
Open

promptly seems outdated #367

jonassmedegaard opened this issue Apr 3, 2022 · 16 comments
Labels
good first issue Good for newcomers

Comments

@jonassmedegaard
Copy link

promptlyhasn't seen an update in 2 years, and depends on old duplicate branches of some libraries.

Perhaps sensible to switch to another library, e.g. enquirer?

@joepio
Copy link
Member

joepio commented Apr 3, 2022

Goot catch. enquirer also provides a far nicer UI.

@joepio
Copy link
Member

joepio commented Apr 9, 2022

I started using enquirer in atomic-server, it's pretty neat

@jonassmedegaard
Copy link
Author

Not yet pushed, or do you really mean dialoguer?

@joepio
Copy link
Member

joepio commented Apr 9, 2022

Yeah, dialoguer is the lib behind enquirer

@jonassmedegaard
Copy link
Author

heh - how could I miss that :-)

@joepio
Copy link
Member

joepio commented Apr 9, 2022

dialoguer doesn't seem to support optional inputs that well. See issue

@LeoDog896
Copy link

You can wrap around it using an Option if you would like

@joepio
Copy link
Member

joepio commented Mar 11, 2023

Seems like promptly is being maintained again, last update 9 months ago. I started a branch with dialoguer some time ago, which seems fine, but I have too many other things that take priority over this issue. Anyone reading this: feel free to pick it up!

@joepio joepio added the good first issue Good for newcomers label Mar 11, 2023
@jonassmedegaard
Copy link
Author

Seems like promptly is being maintained again, last update 9 months ago.

...and more than a year later the promptly project is still silent :-(

I am no longer able to build atomic-server using crates in Debian: promptly depends on outdated rustyline 9, and even if "cheating" and embedding local copy of that (which means security tracking for that component is severely hampered), that depends on outdated nix 0.23 which could be patched to use Debian-maintained nix up until 0.26, but now fails to build with nix 0.27.

I will try fumble with your preliminary patch for switching away from promptly, but doubt that my Rust skills are sufficient, and in that case I may have to put on hold my work on getting Atomic server packaged officially for Debian, which is quite frustrating.

@joepio
Copy link
Member

joepio commented Jun 9, 2024

I'll try dialoguer again!

joepio added a commit that referenced this issue Jun 9, 2024
@joepio
Copy link
Member

joepio commented Jun 9, 2024

Blocked: console-rs/dialoguer#186

@jonassmedegaard
Copy link
Author

I have been fighting this since my previous post here (module a bit of sleep), and possibly have a patch very soon (compiles but I haven't tested in a console yet).

@jonassmedegaard
Copy link
Author

My patch is here

@jonassmedegaard
Copy link
Author

...and here's my attempt at refining to do validation more integrated (with one nit commented out that I couldn't figure out).

Now I am waiting for my slow compliation to complete, so I can actually test if it works at all (my system is not tuned for development but for packaging, so it is cumbersome for me to do iterative non-optimized builds).

@joepio
Copy link
Member

joepio commented Aug 27, 2024

Hey @jonassmedegaard thanks for the patches! Did the tests succeed?

I tried applying the patches locally but it seems to fail. Could you try to rebase onto develop and open a PR?

I tried at #377 some time ago but failed

@jonassmedegaard
Copy link
Author

My patch applies cleanly to HEAD of your master branch.
I cannot build and test currently, due to a bug elsewhere in the dependency chain on Debian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants