Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No redundant temporary variables #68

Open
constgen opened this issue Jun 24, 2020 · 0 comments
Open

No redundant temporary variables #68

constgen opened this issue Jun 24, 2020 · 0 comments
Labels
rule Validation rule

Comments

@constgen
Copy link
Contributor

constgen commented Jun 24, 2020 •
edited
Loading

Disallow usage of unnecessary intermediate variables. They may confuse readers of the code

This code should return an ERROR

let now = Date.now()
message.lastViewTime = now

This is CORRECT

message.lastViewTime = Date.now()

So if a variable is used only once and it is the only operand of the assignment = operator then it is a violation of this rule
@constgen constgen added the rule Validation rule label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule Validation rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@constgen