Skip to content
This repository has been archived by the owner on Jul 20, 2021. It is now read-only.

Merging? #2

Open
carlosalberto opened this issue Mar 26, 2013 · 4 comments
Open

Merging? #2

carlosalberto opened this issue Mar 26, 2013 · 4 comments

Comments

@carlosalberto
Copy link

No description provided.

@carlosalberto
Copy link
Author

Hey dude!

I've been working on the indent/policy/formatter side, which has been slow, but the intention is to be a clear, real port from the C# one.

It's in https://github.com/carlosalberto/TypeScriptBinding repo.

So far I've been able to test it, make sure indentation works for most of the stuff, and so on (this working stuff is like a Vim mode for TS, so far).

There are still some things to be added (like support for the 'with' statement), but in general it works nice and smooth.

The next step for me, is to get the Formatter done, and for that, I need a real Parser around, and thus my idea of merging. Thus the questions:

*Do you still plan to continue with your effort?

  • If so, would it be ok to create a pull request to put my effort and merge into yours (at least in a branch)?

If yo do not plan to move head, I could likely take some pieces of your code (I already took the syntax highlighting, for making my life easier while testing TS code ;) )

Lemme know!

@atsushieno
Copy link
Owner

Whoa, sorry Carlos, I didn't notice the issue for long time...! I haven't worked on this project for long time (I couldn't work on almost anything this year) so hopefully it hasn't changed a lot since you forked. In next few weeks I'll have a look and hopefully merge your changes (I'm still busy in private time, having to audit a big chunk of .NET related translations, so not right now...). Thanks!

@carlosalberto
Copy link
Author

Oh well, same here, I posted the pull request before leaving on trips ;) So no worries.

And same here, haven't added anything new, but I've spent a pair of weeks now playing with the actual TypeScript api for the AST and that kind of stuff :)

@atsushieno
Copy link
Owner

Hey Carlos,

I just imported your code formatting extension into my tree! But I don't know how I can check your extensibility ;-) How exactly can I see that?

I disabled the following part in addin.xml, and pasted some unformatted .ts source buffer into an editor window, and it just formatted the code.

<Extension path = "/MonoDevelop/Ide/CodeFormatters">
    <Formatter mimeType="text/x-typescript" class="TypeScriptBinding.Formatting.TypeScriptFormatter" />
</Extension>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants