Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: TypeScript definitions need to be updated to allow strings or booleans #3

Closed
zshall opened this issue Apr 13, 2020 · 0 comments
Closed

Bug: TypeScript definitions need to be updated to allow strings or booleans #3

zshall opened this issue Apr 13, 2020 · 0 comments

Comments

@zshall
Copy link
Contributor

zshall commented Apr 13, 2020

In index.d.ts, the combo() function defines shortcuts as string[]. Now that we've made implemented #1 , We'll need to update the TypeScript definition to allow (string|boolean)[].

I didn't catch this until this morning when I updated my TS codebase to the new version. D'oh!
zshall added a commit to zshall/aurelia-combo that referenced this issue Apr 13, 2020
@zshall
aurelia-contrib#3 --- Add booleans to the TypeScript definition for `…
2bb1bec 
…@combo()`
@3cp 3cp closed this as completed Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zshall @3cp