-
Notifications
You must be signed in to change notification settings - Fork 194
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certificate verify failed when running unit tests on macbook for nltk data download #199
Comments
Hi, I cannot replicate this, are you sure that the network you're running this from doesn't intercept your traffic? You shouldn't need to run without SSL verification.
|
It could be that the network does, but this I cannot control. I have had similar SSL issues when installing some python packages in the past. Especially on VPN. This time I used the hotspot shared with my phone, as I was in transit. EDIT: Regardless, why is SSL necessary for this use case? Aren't we just downloading a public dataset? My fix enables people to run tests and download datasets using nltk without strict requirements on SSL. |
As we're downloading a public dataset from a third party, we want to keep a strict SSL requirement to prevent against cybersec vulnerabilities (man-in-the-middle comes to mind first). Closing for now |
OK, thats understandable. Thanks for the clarification, @bruvduroiu! :] |
Issue
When trying to run the unit tests for testing my development branches, I am unable to download the datasets. This blocks me from performing the tests.
Quick-fix
It seems like I can manually download these myself, using a custom fix. Instead of doing:
I can do:
Solution
So having this fix seems relevant for this project. Could be that the issue is from some other library, but for now, it seems to be related to when initializing the
BM25Encoder
model. I would think other models which use datasets fromnltk
also could have issues.I can draft a PR, if it is relevant to this project. If not, I can make a PR to whichever repo this issue originates from.
PyTest logs
The text was updated successfully, but these errors were encountered: