Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync setting parameter to Index #340

Closed
jamescalam opened this issue Jul 5, 2024 · 0 comments · Fixed by #344
Closed

Add sync setting parameter to Index #340

jamescalam opened this issue Jul 5, 2024 · 0 comments · Fixed by #344
Assignees
Labels
enhancement Enhancement to existing features

Comments

@jamescalam
Copy link
Member

Should add sync setting to BaseIndex base class (with NotImplemented) and actual implementation to be added in PineconeIndex. Should (probably) incl:

  • sync="error" — if local and remote not synchronized raise error
  • sync="remote" — if local and remote not synchronized take remote as true (and update local to align)
  • sync="local" — if local and remote not synchronized take local as true (and update remote to align)
  • sync="merge" — if local and remote not synchronized merge both, adding routes from remote to local and vice-versa
@jamescalam jamescalam added the enhancement Enhancement to existing features label Jul 5, 2024
@Vits-99 Vits-99 linked a pull request Jul 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants