Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync feature not handling non-existing local routes present remotely #357

Closed
Vits-99 opened this issue Jul 16, 2024 · 0 comments · Fixed by #358
Closed

Sync feature not handling non-existing local routes present remotely #357

Vits-99 opened this issue Jul 16, 2024 · 0 comments · Fixed by #358
Assignees
Labels
bug Something isn't working

Comments

@Vits-99
Copy link
Contributor

Vits-99 commented Jul 16, 2024

Sync feature is not functioning correctly when local routes do not exist but are present remotely.

Steps to Reproduce:

  1. In Pinecone, define the following routes:
    ("politics", "isn't politics the best thing ever")
    ("politics", "why don't you tell me about your political opinions")
  1. Locally, define the following route:
    chitchat = Route(
        name="chitchat",
        utterances=[
            "how's the weather today?",
            "how's the weather today my super duper dear?",
            "how are things going?",
            "how are you doing today?"
        ],
    )
    
    routes = [chitchat]
    
    encoder = ...
    pc_index = PineconeIndex(
        ...
        sync="merge-force-local"
    )
    
    rl = RouteLayer(encoder=encoder, routes=routes, index=pc_index)
           print(rl("What do you think about the president?"))

Expected Behavior:
When using a politics input to layer we expect to get politics route correctly triggered.

Actual Behavior:
An error is returned indicating that no route with the name "politics" is found locally:
ERROR semantic_router.utils.logger No route found with name politics. Check to see if any Routes have been defined

@Vits-99 Vits-99 self-assigned this Jul 16, 2024
@Vits-99 Vits-99 added the bug Something isn't working label Jul 16, 2024
@Vits-99 Vits-99 linked a pull request Jul 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant