Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create function to update metadata in FT contracts #48

Open
3 tasks
mfornet opened this issue Jun 21, 2021 · 3 comments · May be fixed by #53
Open
3 tasks

Create function to update metadata in FT contracts #48

mfornet opened this issue Jun 21, 2021 · 3 comments · May be fixed by #53
Assignees
@0x3bfc
Labels
enhancement New feature or request P3

Comments

@mfornet
Copy link
Contributor

mfornet commented Jun 21, 2021

After ERC20 tokens are bridged to NEAR as NEP141 the metadata needs to be updated. This is also the case when tokens are deployed as ERC20 inside Aurora. This issue tracks the implementation of helper functions to do this safely using a library.

The issue is opened in this library, since the logic for this should be implemented in this repository, and then we should be using it from CLI tool and frontend.

Tasks involved:

  • Pull metadata from ERC20 contracts in Ethereum.
  • Push metadata to NEP-141 in NEAR. Use this function to update NEP141 metadata
  • Push metadata to ERC-20 contracts inside Aurora. Use AdminControlled interface for updating storage inside contracts.

Notice that for pushing information, they can only be done with from some particular accounts (owner accounts). It would be useful to throw a meaningful error in case the account used is not the expected one.
@mfornet mfornet added enhancement New feature or request P3 labels Jun 21, 2021
@mfornet
Copy link
Contributor Author

mfornet commented Jun 21, 2021

@paouvrard it would be useful to have your input, on where this functions should live.

@paouvrard
Copy link
Member

@mfornet
Tasks 1 and 2 (pulling metadata from ERC-20 and updating NEP-141) could go in nep141-erc20 and task 3 (pushing metadata to Aurora) could go in aurora-erc20. But we can also make a metadata package or add it to utils if we don't want them to be separated.
If we plan to make a connector to trustlessly bridge metadata, then I think having a metadata connector package in the client libs makes sense.

@0x3bfc
Copy link
Contributor

0x3bfc commented Jun 22, 2021

If we plan to make a connector to trustlessly bridge metadata, then I think having a metadata connector package in the client libs makes sense.

I'd say if we will have this especially for only bridging the ERC-20 metadata, then It should go to nep141-erc20 and aurora-erc20 but if it will be more generic for bridging any contract's metadata to aurora, then it should be in a separate package.

@0x3bfc 0x3bfc linked a pull request Jul 2, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x3bfc 0x3bfc

Labels
enhancement New feature or request P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ft metadata aurora-is-near/rainbow-bridge-client
3 participants
@0x3bfc @mfornet @paouvrard