Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-288] Add Support for WithSynchronousRefresh Option in CachingProvider for Blocking/Non-Blocking Key Refresh #314

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

[GH-288] Add Support for WithSynchronousRefresh Option in CachingProvider for Blocking/Non-Blocking Key Refresh #314

wants to merge 24 commits into from

Conversation

developerkunal
Copy link
Contributor

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

🔧 Changes

Added support for blocking and non-blocking key refresh in CachingProvider by introducing the WithSynchronousRefresh option.

  • Added WithSynchronousRefresh option to allow developers to choose between blocking and non-blocking key refresh.
  • Updated CachingProvider to respect the selected refresh mode.
  • Ensured backward compatibility by defaulting to non-blocking refresh.

📚 References

🔬 Testing

  • Added unit tests to verify both blocking and non-blocking behavior.
  • Validated that the change does not impact existing non-blocking behavior unless explicitly enabled.

@developerkunal developerkunal requested a review from a team as a code owner February 13, 2025 08:48
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (f0aafb9) to head (ac36e8c).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   96.39%   96.66%   +0.26%     
==========================================
  Files           8        8              
  Lines         361      390      +29     
==========================================
+ Hits          348      377      +29     
  Misses         10       10              
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal developerkunal linked an issue Feb 14, 2025 that may be closed by this pull request
Race condition in JWK Caching Provider implementation? #288
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition in JWK Caching Provider implementation?
2 participants
@developerkunal @codecov-commenter