Skip to content

Commit 0078a01

Browse files
committed
fixess
1 parent ffac304 commit 0078a01

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

lib/passport-wsfed-saml2/saml.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,6 @@ class SAML {
245245

246246
const now = new Date();
247247

248-
// ideally, the parameters provided to new Date would validate that produce a valid date object, but for the
249-
// rollout we will maintain the same behavior we currently have to prevent introducing additional breaking changes
250-
251248
if (notBefore) {
252249
const notBeforeDate = new Date(notBefore);
253250
notBeforeDate.setMinutes(notBeforeDate.getMinutes() - this.options.clockSkew);

lib/passport-wsfed-saml2/samlp.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ class Samlp {
212212
try {
213213
// we are not converting SAMLRequest into a DOM before sending to xml-crypto because at the current time we allow the following test:
214214
// invalid CDATA xml that does not cause an error. This probably *should* cause an error, but it doesn't.
215-
// in a subsequent release we should address this.
216215
sig.computeSignature(SAMLRequest, { location: { reference: "//*[local-name(.)='Issuer']", action: 'after' } }); // Signature element must be located after Issuer
217216
} catch (e) {
218217
return callback(new Error('fail to compute signature'));

0 commit comments

Comments
 (0)