Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OpenTelemetry collectors #14

Closed
jzelinskie opened this issue Aug 17, 2021 · 7 comments · Fixed by #491
Closed

Support OpenTelemetry collectors #14

jzelinskie opened this issue Aug 17, 2021 · 7 comments · Fixed by #491
Labels
area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) hint/good first issue Someone new could handle this kind/tech debt Addresses legacy code/decisions priority/4 maybe This might get done someday

Comments

@jzelinskie
Copy link
Member

Everything is instrumented using OpenTelemetry, but Jaeger is the only format exposed by command-line flags.
If it can be made generic enough, this could be upstreamed into cobrautil.
@jzelinskie jzelinskie added area/CLI Affects the command line priority/4 maybe This might get done someday area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) kind/tech debt Addresses legacy code/decisions labels Aug 17, 2021
@jzelinskie jzelinskie added the hint/good first issue Someone new could handle this label Oct 27, 2021
@jzelinskie jzelinskie changed the title Expose tracing flags for more formats Support OpenTelemetry collectors Nov 8, 2021
@jzelinskie
Copy link
Member Author

This is done by using OpenTelemetry collectors, which I'm fairly certain Jaeger is being written to support natively.
Ideally we can just support configuring a collector endpoint and that's all that's necessary from within SpiceDB.

This was referenced Jan 26, 2022
Merged
Merged
@jzelinskie
Copy link
Member Author

Any changes to flags need to be backwards compatible, so any PR that fixes this would have to mark the existing jaeger flags as hidden and introduce new ones.

@josephschorr
Copy link
Member

@jzelinskie: was this done in jzelinskie/cobrautil@21e5e5d?

@jzelinskie
Copy link
Member Author

The changes to cobrautil have been made, but the SpiceDB still needs to add a new flag for it (because it's not backcompat) and then mark the existing jaeger flag as hidden.

@jzelinskie
Copy link
Member Author

@cjs @christroger are either of ya'll still interested in taking this on?

@cjs
Copy link
Contributor

cjs commented Mar 9, 2022

Yes we will take care of it. I think we also need to do another PR against cobrautil to fix an issue with getting some OTel parameters from the environment.

@jzelinskie jzelinskie mentioned this issue Mar 9, 2022
Closed
@christroger
Copy link
Contributor

As an update here, I opened a PR for the fix of the OTEL_RESOURCE_ATTRIBUTES env var. jzelinskie/cobrautil#5

jzelinskie added a commit that referenced this issue Mar 21, 2022
@jzelinskie
pkg/cmd: use cobrautil version command
75b76f4 
This also updates to a version that supports generic OpenTelemetry
collectors.

Fixes #14.
@jzelinskie jzelinskie mentioned this issue Mar 21, 2022
Merged
jzelinskie added a commit that referenced this issue Mar 24, 2022
@jzelinskie
pkg/cmd: use cobrautil version command
05ae70d 
This also updates to a version that supports generic OpenTelemetry
collectors.

Fixes #14.
winstaan74 added a commit to winstaan74/docs that referenced this issue Oct 19, 2023
@winstaan74
Update feature-overview.md
0cba033 
Issue authzed/spicedb#14 was closed in March - so updated docs to reflect that any OpenTelemetry Collector can be used.
@winstaan74 winstaan74 mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) hint/good first issue Someone new could handle this kind/tech debt Addresses legacy code/decisions priority/4 maybe This might get done someday
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/cmd: use cobrautil version command authzed/spicedb
4 participants
@cjs @jzelinskie @josephschorr @christroger