Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exemplar support #44

Open
emschwartz opened this issue May 12, 2023 · 2 comments
Open

Exemplar support #44

emschwartz opened this issue May 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@emschwartz
Copy link

Not entirely sure what the support is like upstream: open-telemetry/opentelemetry-go#559

@gagbo
Copy link
Member

gagbo commented May 12, 2023

It seems the blocking issue for autometrics is this issue open-telemetry/opentelemetry-go#3163

As long as that is not fixed I don't think there's much we can do. Exemplars as a datastructure attached to datapoints exist in the SDK codebase but I found no way to add Exemplars to counters in the OpenTelemetry codebase. All it can do is add "attributes" that end up being labels in the Prometheus export

The prometheus client does have support for adding exemplars it seems, but it looks like we need to specify what we want as exemplars, since both key and value are mostly free-form fields. I'm not sure what's the good way to try to extract the traceID/spanID in a "framework agnostic" way in Go, it'll take some research I think

@gagbo
Copy link
Member

gagbo commented Nov 6, 2023

This is done for Prometheus, still waiting on something for opentelemetry, but we can probably just use tracing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants